Dep updates and expansion of ruff CI #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvandyken
added
the
maintenance
kaitj
reviewed
Dec 14, 2023
pvandyken
force-pushed
the
maint/dep-updates
branch
from
8289af2 to
7e24147
Compare
Switch all formatting to ruff, as opposed to black and isort Enable - pep8-naming - pycodestyle warning rules - pydocstyle - flake8-2020 - flake8-bandit - flake8-blind-except - flake8-bugbear - flake8-builtins - flake8-commas - flake8-comprehensions - flake8-debugger - flake8-errmsg - flake8-future-annotations - flake8-implicit-str-concat - flake8-import-conventions - flake8-logging-format - flake8-no-pep420 - flake8-pie - flake8-pytest-style - flake8-raise - flake8-return - flake8-self - flake8-simplify - tryceratops - flynt - narrow subset of perflint
pvandyken
force-pushed
the
maint/dep-updates
branch
from
7e24147 to
14672f7
Compare
kaitj
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ruff now supports black-compatible formatting, I decided to drop our
blackandisortdependencies and switch fully over to ruff. I also enabled all the ruff rule sets that I thought made sense for this repo. Notably, nothing to do with type checking (pyright handles that). Our code base was already quite conventional, so enabling most of these wasn't too burdensome, mostly a good chance to catch up on docstrings!I left the ruleset additions sprawled across the commits to make it easier to see what rules enforced what changes. There's no intentional behavioural changes, so assuming the tests pass, I'll just wait for one review here.